-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Footer #13
Open
saraswati789
wants to merge
7
commits into
sarthakkundra:master
Choose a base branch
from
saraswati789:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added Footer #13
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ff476b
Add files via upload
saraswati789 a6af855
Merge pull request #1 from saraswati789/saraswati789-pull_request
saraswati789 de3151c
Delete pull_request_template.md
saraswati789 6a883bd
Added pull_request.md
saraswati789 93ae372
Merge
saraswati789 694dcb6
Merge branch 'master' of https://github.com/saraswati789/Github-Finder
saraswati789 22eee7b
.
saraswati789 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
(Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.) | ||
|
||
What does this implement/fix? Explain your changes. | ||
--------------------------------------------------- | ||
… | ||
|
||
Does this close any currently open issues? | ||
------------------------------------------ | ||
… | ||
|
||
|
||
Any relevant logs, error output, etc? | ||
------------------------------------- | ||
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.) | ||
|
||
Any other comments? | ||
------------------- | ||
… | ||
|
||
Where has this been tested? | ||
--------------------------- | ||
**Operating System:** … | ||
|
||
### Your checklist for this pull request | ||
🚨Please review the [guidelines for contributing](../CONTRIBUTING.md) to this repository. | ||
|
||
- [ ] Make sure you are requesting to **pull a feature/bug branch**. Don't request your master! | ||
- [ ] Check the commit's or even all commits' message styles matches our requested structure. | ||
- [ ] Check your code additions will fail neither code linting checks(programmatic errors and stylistic errors) | ||
|
||
### Description | ||
Please describe your pull request. | ||
|
||
💔Thank you! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import React from 'react' | ||
|
||
const footerStyles = { | ||
backgroundColor: '#e3143e', | ||
bottom: 0, | ||
} | ||
|
||
const anchorStyles = { | ||
color: '#f7f7f5' | ||
} | ||
|
||
const FooterWrapper = class extends React.Component { | ||
render() { | ||
return ( | ||
<div className = "app-footer"> | ||
<footer className="footer" style = {footerStyles}> | ||
|
||
<div className="content"> | ||
<div className="container has-background-black has-text-white-ter"> | ||
<div style={{ maxWidth: '100vw' }} className="columns"> | ||
<div className="column is-4"> | ||
<a title="Report a bug on our Github Repo" style = {anchorStyles} href="https://github.com/sarthakkundra/Github-Finder/issues"> | ||
Report a bug | ||
</a> | ||
</div> | ||
<div className="column is-4"> | ||
<a title="Request a feature" style = {anchorStyles} href="https://github.com/sarthakkundra/Github-Finder/issues"> | ||
Request a feature | ||
</a> | ||
</div> | ||
<div className="column is-4"> | ||
<a title="Contribute" style = {anchorStyles} href="https://github.com/sarthakkundra/Github-Finder"> | ||
Contribute to Repository | ||
</a> | ||
|
||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</footer> | ||
</div> | ||
) | ||
} | ||
} | ||
|
||
export default FooterWrapper |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import React from "react" | ||
import FooterWrapper from "../layouts/FooterElements" | ||
|
||
const Footer = () => { | ||
return <FooterWrapper> | ||
|
||
</FooterWrapper> | ||
|
||
} | ||
|
||
export default Footer |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
column is-4
a Chakra UI class? If not where is it defined?