-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Support Flat configs in v8 #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this will be semver-minor
e08a7e5
to
dfd671e
Compare
@lotmek it looks like the exception is always being thrown. |
Hello @ljharb, tell me if I'm wrong, but I think flat configs are not supported in ESLint v7 I can add a condition to skip the flat config tests if ESLint version is lower than 8, what do you think of it ? if (semver.satisfies(eslintPkg.version, '>= 8')) {
describe('flat config', () => {
...
})
} |
I have eslint 8.56 installed and it's still failing locally, fwiw. Certainly the flat config tests should be ensuring it throws in eslint 7, good catch. |
I did some changes, can you try again ? |
b690889
to
de07149
Compare
LGTM, thanks |
Description
rule-finder.js
--flatConfig
flag