fix(rule-finder): pass a file to getConfigForFile #306
Conversation
This fixes a compatibility issue with eslint@6 which now passes the given file to `path.resolve` (https://github.com/eslint/eslint/blob/1fb362093a65b99456a11029967d9ee0c31fd697/lib/cli-engine/cli-engine.js#L905) which will throw if no file is given.
| @@ -23,7 +23,7 @@ function _getConfig(configFile) { | |||
| // Point to the particular config | |||
| configFile | |||
| }); | |||
| return cliEngine.getConfigForFile(); | |||
There was a problem hiding this comment.
doesn't this only return the proper config for the config file, which might be yaml or .eslintrc json?
Config files are often not JS.
There was a problem hiding this comment.
Perhaps. Consider this more of a bug report than a PR then. I'm not sure what the proper solution for this is. Because for this project there's not really a specific file that we're looking for a config for 🤔
There was a problem hiding this comment.
#304 is the bug report, which includes my latest attempt: master...ljharb:eslint_6
There was a problem hiding this comment.
🤦♂ I apologize. Totally didn't even think to check whether it had been reported. This is embarrassing.
There was a problem hiding this comment.
No worries, to be fair I was super excited when I saw the PR notification because this package's v6 support is blocking me in two shared configs :-/
There was a problem hiding this comment.
@ljharb (or anyone else looking for issues related to .js configs as I was and finding this comment)
re:
Config files often not JS.
by the way:
If you look at the top eslint configs on the first page of NPM, 12 out of the 18 use the .js config style (as opposed to .json or .yaml). The list of popular configs using this style includes:
- eslint-config-airbnb
- eslint-config-alloy
- eslint-config-amo
- eslint-config-canonical
- eslint-config-create-react-app
- eslint-config-expo
- eslint-config-fbjs
- eslint-config-google
- eslint-config-peerigon
- eslint-config-prettier
- eslint-config-synacor
- eslint-config-vi
- eslint-config-vue
(I already had this list)
There was a problem hiding this comment.
sure, but these are the top shared configs. I have 200 packages that only use the rc form, and a shared config for many of them that also does. Config files are indeed often not JS, even though they are also often JS :-)
This fixes a compatibility issue with eslint@6 which now passes the given file to
path.resolve(https://github.com/eslint/eslint/blob/1fb362093a65b99456a11029967d9ee0c31fd697/lib/cli-engine/cli-engine.js#L905) which will throw if no file is given.I tried this locally and it works without issue.