Version Bump (#996)

* fix navigation pop error by canceling PopScope action if pop is alredy confirmed * - Refactor PopScope to pop if the player is not in fullscreen instead of always false. - Remove `Navigator.pop` inside `onPopInvokedWithResult` to avoid issues with external navigation (Example: Pressing dialog barrier, or using an external navigation solution) * 🎨 formaating fixes * fix: Full Screen in Landscape mode cut the video #621 (#962) * Full Screen in Landscape mode cut the video #621 * Full Screen in Landscape mode cut the video #621 * 🎨 minor changes * 🔖 bumped version * minor change --------- Co-authored-by: RaphiTobi <[email protected]> Co-authored-by: abulmajd <[email protected]> Co-authored-by: Nhật Long <[email protected]>
sarbagyastha · Sep 20, 2024 · 3a21073 · 3a21073
1 parent a5e03fc
commit 3a21073
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/packages/youtube_player_flutter/CHANGELOG.md b/packages/youtube_player_flutter/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 9.0.4
+* Fixes related to fullscreen toggle.
+
 ## 9.0.3
 * Fixes issue where loading indicator would always show.
 * Updates the default color of the progress indicator to be primary container color.

diff --git a/packages/youtube_player_flutter/lib/src/widgets/youtube_player_builder.dart b/packages/youtube_player_flutter/lib/src/widgets/youtube_player_builder.dart
@@ -67,11 +67,12 @@ class _YoutubePlayerBuilderState extends State<YoutubePlayerBuilder>
 
   @override
   Widget build(BuildContext context) {
-    final double height = MediaQuery.of(context).size.height;
+    final orientation = MediaQuery.orientationOf(context);
+    final height = MediaQuery.sizeOf(context).height;
 
-    final player = Container(
+    final player = SizedBox(
       key: playerKey,
-      height: (MediaQuery.of(context).orientation == Orientation.landscape) ? height : null,
+      height: orientation == Orientation.landscape ? height : null,
       child: PopScope(
         canPop: !widget.player.controller.value.isFullScreen,
         onPopInvokedWithResult: (didPop, _) {

diff --git a/packages/youtube_player_flutter/pubspec.yaml b/packages/youtube_player_flutter/pubspec.yaml
@@ -1,6 +1,6 @@
 name: youtube_player_flutter
 description: Flutter plugin for playing or streaming inline YouTube videos using the official iFrame player API. This plugin supports both Android and iOS.
-version: 9.0.3
+version: 9.0.4
 repository: https://github.com/sarbagyastha/youtube_player_flutter
 homepage: https://github.com/sarbagyastha/youtube_player_flutter/tree/master/packages/youtube_player_flutter
 
@@ -16,7 +16,7 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  mocktail: ^1.0.3
+  mocktail: ^1.0.4
 
 flutter:
   uses-material-design: true