Prevent uploading artifacts from pull requests. Do it only from merge…

…s, since the secrets are not defined and it fails.
sarah-walker-pcem · Jun 19, 2024 · ee9119f · ee9119f
1 parent dd67941
commit ee9119f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml
@@ -167,8 +167,10 @@ jobs:
 
       - name: Upload to NasuTek MinIO S3
         uses: shallwefootball/s3-upload-action@master
+        env: 
+            super_secret: ${{ secrets.nte_cdn_s3_key_id }}
+        if: ${{ env.super_secret == '' }}
         id: S3
-        if: secrets.nte_cdn_s3_key_id != null
         with:
           aws_key_id: ${{secrets.nte_cdn_s3_key_id}}
           aws_secret_access_key: ${{secrets.nte_cdn_s3_secret_access_key}}

diff --git a/.github/workflows/test-debug-builds.yml b/.github/workflows/test-debug-builds.yml
@@ -164,7 +164,9 @@ jobs:
 
             - name: Upload to NasuTek MinIO S3
               uses: shallwefootball/s3-upload-action@master
-              if: secrets.nte_cdn_s3_key_id != null
+              env: 
+                  super_secret: ${{ secrets.nte_cdn_s3_key_id }}
+              if: ${{ env.super_secret == '' }}
               id: S3
               with:
                   aws_key_id: ${{secrets.nte_cdn_s3_key_id}}

diff --git a/.github/workflows/test-release-builds.yml b/.github/workflows/test-release-builds.yml
@@ -164,7 +164,9 @@ jobs:
 
             - name: Upload to NasuTek MinIO S3
               uses: shallwefootball/s3-upload-action@master
-              if: secrets.nte_cdn_s3_key_id != null
+              env: 
+                  super_secret: ${{ secrets.nte_cdn_s3_key_id }}
+              if: ${{ env.super_secret == '' }}
               id: S3
               with:
                   aws_key_id: ${{secrets.nte_cdn_s3_key_id}}

diff --git a/.github/workflows/test-relwithdebinfo-builds.yml b/.github/workflows/test-relwithdebinfo-builds.yml
@@ -164,7 +164,9 @@ jobs:
 
             - name: Upload to NasuTek MinIO S3
               uses: shallwefootball/s3-upload-action@master
-              if: secrets.nte_cdn_s3_key_id != null
+              env: 
+                  super_secret: ${{ secrets.nte_cdn_s3_key_id }}
+              if: ${{ env.super_secret == '' }}
               id: S3
               with:
                   aws_key_id: ${{secrets.nte_cdn_s3_key_id}}