feat: add interaction support to args #728
Conversation
|
@vladfrangu please review this PR (as discussed in DMs) |
There was a problem hiding this comment.
For starters, this is more-less what I'd personally want for Args v2: https://vladfrangu.notion.site/Args-v2-183d858b10e64cd6b942e56f1b04a405?pvs=4
You can also split up Argument#run into messageRun and chatInputRun if it'd be better for you (since chat command args also come with a type, we should assert the types match the inputs too!)
|
@vladfrangu Tried to make args abstract based on that document. I had to fight typescript to get peek to work, but I'm not sure how to do it better. |
|
Also I cannot express enough with words that I am hella grateful that you're taking on this (quite challenging) issue! Don't let the barrage of requested changes scare you! ❤️ |
|
Thanks for the kind words! Most of this was just moving stuff to the base class, so it was pretty easy changes. Appreciate that you're taking time to look over it. |
|
@sapphiredev pack this |
|
Heya @vladfrangu, I've started to run the deployment workflow on this PR at 68d8c87. You can monitor the build here! |
|
Packed under |
|
Also, should I be marking conversations as resolved or do you wish to do that? |
Feel free to mark any resolved convo as resolved |
|
@sapphiredev pack this |
|
Heya @vladfrangu, I've started to run the deployment workflow on this PR at d435f5c. You can monitor the build here! |
|
@sapphiredev pack |
|
Heya @vladfrangu, I've started to run the deployment workflow on this PR at 524e708. You can monitor the build here! |
|
@vladfrangu Any updates about this? I'm still not sure if my implementation of many() makes sense. |
samfundev
force-pushed
the
main
branch
3 times, most recently
from
ef5ad75
to
4958305
Compare
|
@vladfrangu Any updates about this? |
samfundev
force-pushed
the
main
branch
2 times, most recently
from
6907e59
to
b36892e
Compare
Super rough PR to take a first stab at adding interaction support to
Args. Wanted to get some feedback before going any further since I don't know if I'm going in the right direction with this implementation. Basically,Argsstays the same but either wraps lexure or aChatInputParser.The biggest problem with the current implementation is that
.manydoesn't map very well to slash commands. Would love any suggestions.Resolves #494