Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict mode from Interfaces #266

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Remove strict mode from Interfaces #266

merged 1 commit into from
Aug 3, 2021

Conversation

groenroos
Copy link
Member

As part of #222 and #247, all instances of strict mode were removed. However, the linter is told to ignore Interface files, so the strict mode declarations there remained.

@groenroos groenroos added the maintenance Keep dependencies, code and conventions fresh label Aug 3, 2021
@groenroos groenroos self-assigned this Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #266 (283d80c) into master (304b88e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   96.66%   96.65%   -0.01%     
==========================================
  Files          35       35              
  Lines        4344     4340       -4     
==========================================
- Hits         4199     4195       -4     
  Misses        145      145              
Impacted Files Coverage Δ
drivers/db/Interface.js 100.00% <ø> (ø)
drivers/render/Interface.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 304b88e...283d80c. Read the comment docs.

@groenroos groenroos merged commit fbc9576 into master Aug 3, 2021
@groenroos groenroos deleted the fix/remove-strict branch August 3, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Keep dependencies, code and conventions fresh
Development

Successfully merging this pull request may close these issues.

1 participant