Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement brute force protection #49

Open
groenroos opened this issue Sep 2, 2020 · 1 comment
Open

Implement brute force protection #49

groenroos opened this issue Sep 2, 2020 · 1 comment
Assignees
Labels
feature Brand new features to Sapling low priority Issues which should only be considered after everything else is done

Comments

@groenroos
Copy link
Member

Use a package like express-brute to introduce a rate limiter and protect from DDoS. The legacy code had a homebrew rate limiter, but this was removed as a temporary scope reduction - in any case, this sort of thing is best deferred to dependencies that can handle it better and more robustly.

@groenroos groenroos added feature Brand new features to Sapling low priority Issues which should only be considered after everything else is done labels Sep 2, 2020
@groenroos groenroos added this to the M2 - Release 2.0 milestone Sep 2, 2020
@groenroos groenroos self-assigned this Sep 2, 2020
groenroos added a commit that referenced this issue Sep 2, 2020
@groenroos
Copy link
Member Author

Seems like the brute package listed above is a bit outdated/abandoned. However, it seems like it and all alternative packages require persistent storage (as would make sense), so it'll be a challenge to make sure the rate limiter works together with whatever db driver is applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new features to Sapling low priority Issues which should only be considered after everything else is done
Development

No branches or pull requests

1 participant