This repository has been archived by the owner on May 29, 2020. It is now read-only.
Use relativeFontPath in HTML demo #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the generated CSS was taking into account the relativeFontPath but the HTML demo was not.
|
I am not sure why this test is failing on travis-ci. All tests pass locally and when I run the tests without the clean at the end this is the result of the tests. As you can see there are no files that are outside of the |
|
It's only failing on node v5+. What version of node are you running locally? |
|
Yeah, and I don’t think it fails because of your changes. It fails in master with Node 5.7.0 (was fine in 5.6.0) on my Mac too. |
|
Here is the reason: gruntjs/grunt-contrib-clean#85 |
|
Ah, yes that would explain it. I am running Node v 5.3.0. |
|
Looks like it’s Node bug (see the comments by the link above). |
sapegin
added a commit
that referenced
this pull request
Feb 29, 2016
Use relativeFontPath in HTML demo
|
Out in 1.2.0, thanks! (As well as new Node 5.7.1 that fixes a bug that caused tests to fail.) |
|
My demo.html crashed because the variable o.relativeFontPath is an empty string and new RegExp with an empty string appends it to anything. My demo.html contains the following: That's the expected code: Temporary I fixed it with a short if condition. I'm not sure if this would be the best solution: fry2k@bab011e A Temporary solution for me is also set the option options.relativeFontPath to the same value like dest at the grunt task-definition dest, destCss and destHtml have all the same path at my env: "dist/font" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the generated CSS was taking into account the relativeFontPath but the HTML demo was not.