Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade way how the api-server metrics are served #3

Open
ArtieReus opened this issue Oct 27, 2021 · 0 comments
Open

Upgrade way how the api-server metrics are served #3

ArtieReus opened this issue Oct 27, 2021 · 0 comments

Comments

@ArtieReus
Copy link
Collaborator

warning: prometheus.InstrumentHandler is deprecated: InstrumentHandler has several issues. Use the tooling provided in package promhttp instead. The issues are the following: (1) It uses Summaries rather than Histograms. Summaries are not useful if aggregation across multiple instances is required. (2) It uses microseconds as unit, which is deprecated and should be replaced by seconds. (3) The size of the request is calculated in a separate goroutine. Since this calculator requires access to the request header, it creates a race with any writes to the header performed during request handling. httputil.ReverseProxy is a prominent example for a handler performing such writes. (4) It has additional issues with HTTP/2, cf. prometheus/client_golang#272. (SA1019) (staticcheck)

See how it can be fixed here:
https://gitlab.cncf.ci/prometheus/prometheus/commit/83325c8d822d022fec74d21e2efd15e3b6b6a0af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant