I254 set expandobjects #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamiebull1 , It looks good. I am going to merge. Apologies for the delay. I was distracted by another project that was turning out to be diffcult. I have some thoughts on this change from a higher API level. I'll open that discussion in a seperate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often users have HVACTemplate objects in their IDF, but don't set the
expandobjectsflag when usingIDF.run, leading to anEnergyPlusRunError.I think we should just fix it automatically, by checking if there are any HVACTemplate objects, and setting the flag to
Trueif needed.The only negative impact I see is that there is a cost to reading the IDF, which may add up on multiprocessing jobs, but it's miniscule compared to the actual EnergyPlus running time.