idf.run() does a saveas("in.idf") - is this needed ?

[santoshphilip]

idf.run() does a saveas("in.idf") - is this needed ?

older versions of E+ would simulate the file in.idf
This is not true in the newer versions of E+

Should the saveas("in.idf") be removed ?
It is causing problems in zeppy pyenergyplus/zeppy#20

[santoshphilip]

Observations:

• idf.run() will do a idf.saveas("in.idf") before simulation
• This will change idf.idfname to "in.idf"
• idf.run() does not restore it to it's original name
• not restoring the original name is not what the user would expect

This has not caused users any problems yet, since there have been no issues opened on this. So ignore it for the moment.

Is there a purpose to doing idf.saveas("in.idf") before the run?

• there is a good reason for doing the idf.saveas("in.idf")
• The IDF may have ben created entirely in memory and may not exist on the disk
• changes may have been made to the IDF in memory, but do not exist on the disk.
• But E+ will not run a simulation unless the file is on the disk
• so idf.saveas("in.idf") saves the file to disk and allows the simulation to proceed

Is there a problem with idf.saveas("in.idf"), apart from not restoring the not restoring the original name:

• the idf.saveas("in.idf") creates a problem in distributed systems like zeppy
• zeppy will run two independant simulations - idf1.run() and idf2.run()
• both of them will do a idf.saveas("in.idf")
• this can happen simultaneously or in very close timing
• one in.idf can overwrite the other

Possible solution to the zeppy issue:

• instead of in.idf, generate a long random name sdfejas34.idf
• that will be different for each simulation

[santoshphilip]

Holding off on taking any steps based on the above comment

It would still be useful to have the following functions:

• idf.runfile() -> identical to idf.run(), except that it runs on a file on disk
• eppy.runner.run_functions.runIDFfiles() -> identical to eppy.runner.run_functions.runIDFs(), except that it runs on a file on disk

This has been largely coded and it allows zeppy to work correctly. Open a new issue on this and implement

[santoshphilip]

fixing issue #401 fixed this issue