-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to solve vulnerability #27
Conversation
|
ab98dd0
to
82f8fe1
Compare
I think it should be good now? @santhosh-tekuri |
Cli module is not compiling. Check the logs. I guess you need to add 'ring' feature to rustls in feature module. Please compile locally and verify |
82f8fe1
to
459fde4
Compare
Right, had to update ureq as well since it depends on an olddated rustls. I'm crossing my fingers that everything is good now? @santhosh-tekuri (Also not really used to a rebase-based workflow, I think the idea is that every individual commit should work right? Therefore I amended the commit, but that does mean that you lose your review progress) |
Single commit is good as we are fixing same issue with mistakes. Seems the checks are passing. |
Can you update ureq version in main cargo.toml also |
459fde4
to
377bcb6
Compare
Done |
FYI the commit message has to be modified to follow project convention:
so the commit message will be
|
The goal of this PR is to mitigate a vulnerability in a dependency of this crate
https://rustsec.org/advisories/RUSTSEC-2024-0421.html