test(e2e): restore last e2e tests #7926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Dec 4, 2024 1:33 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Wed, 04 Dec 2024 13:00:59 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
RitaDias
changed the title
RitaDias
requested review from
jordanl17 and
juice49
and removed request for
a team
|
@RitaDias to confirm - the e2es passing in github actions here on the PR is validation that these tests are all passing? |
Yep! |
jordanl17
reviewed
Dec 3, 2024
| @@ -108,6 +108,7 @@ function PaneContextMenuItem(props: {disabled?: boolean; node: _PaneMenuItem}) { | |||
| pressed={node.selected} | |||
| text={title} | |||
| tone={node.tone} | |||
| data-testid={`action-${node.title?.toLocaleLowerCase().replace(' ', '')}`} | |||
There was a problem hiding this comment.
should this also be replaceAll instead of single replace?
There was a problem hiding this comment.
Ah yes, it should! Good catch!
I'll fix this!
There was a problem hiding this comment.
Small related thought: would it make sense to move this to a tiny helper function? I noticed it's repeated a few times, and having the code inline like this doesn't make it super clear to me how/why the node title -> test id transformation works.
There was a problem hiding this comment.
sure, that makes sense :)
juice49
reviewed
Dec 4, 2024
| @@ -108,6 +109,7 @@ function PaneContextMenuItem(props: {disabled?: boolean; node: _PaneMenuItem}) { | |||
| pressed={node.selected} | |||
| text={title} | |||
| tone={node.tone} | |||
| data-testid={`action-${toLowerCaseNoSpaces(node.title)}`} | |||
juice49
previously approved these changes
Dec 4, 2024
bjoerge
added a commit
that referenced
this pull request
Dec 6, 2024
* next: test(sanity): update timeout to avoid slow test from being flaky (#7969) v3.66.1 fix(deps): update dependency @sanity/presentation to v1.19.7 (#7966) fix(core): guard against missing process variable (#7967) fix(sanity): reset search cursor state when any parameter changes (#7889) fix(deps): allow react v19 as peer dependency (#7962) v3.66.0 fix: reword warning about vector images not support crop/hotspot (#7960) fix(deps): Update dev-non-major (#7959) fix(core): add telemetry debug/noop logger (#7958) fix(deps): update dependency @sanity/presentation to v1.19.5 (#7957) fix(core): only open one annotation object edit modal at a time (#7898) fix(cli): remove v2 commands (#5750) feat(cli): generate read token conditionally for remote template (#7953) fix(deps): update dependency @sanity/mutate to ^0.11.1 (#7903) fix(deps): update dependency @sanity/ui to ^2.9.1 (#7948) feat(vision): link to edit documents on `_id`, `_ref` attributes (#6124) fix(core): disable scheduledPublishing and tasks if `/features` returns error (#7517) test(e2e): restore last e2e tests (#7926)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What to review
Review tests and make sure they make sense, I have tried reducing the flakiness but they are e2e tests so 🫠 any pointers would be appreciated.
Testing
This PR is just tests
Notes for release
N/A