feat(structure): squash chunks in timeline. #7458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Sep 4, 2024 7:39 AM (UTC) ✅ All Tests Passed -- expand for details
|
pedrobonamin
commented
Sep 3, 2024
packages/sanity/src/structure/panes/document/timeline/expandableTimelineItemMenu.tsx
Show resolved
Hide resolved
pedrobonamin
requested review from
ryanbonial,
a team and
bjoerge
and removed request for
a team and
ryanbonial
pedrobonamin
force-pushed
the
history-updates
branch
from
7753256
to
a68e82c
Compare
pedrobonamin
force-pushed
the
corel-145
branch
from
44f8ae9
to
8343d67
Compare
|
👋 |
@RitaDias yes, makes sense, I am thinking on proposing to @mariuslundgard using a Caret icon instead of the three dots. Specially considering that we have only 1 action the user can do in this cases. I think it will make it easier to notice that you can expand it. |
RitaDias
reviewed
Sep 5, 2024
pedrobonamin
added a commit
that referenced
this pull request
Oct 1, 2024
* feat(structure): add squashed chunks to timeline * feat(structure): refactor expandable item, all items need to be rendered in the same virtual list * feat(structure): expand elements on menu click * chore(structure): clean timeline item
pedrobonamin
added a commit
that referenced
this pull request
Nov 6, 2024
* feat(structure): add squashed chunks to timeline * feat(structure): refactor expandable item, all items need to be rendered in the same virtual list * feat(structure): expand elements on menu click * chore(structure): clean timeline item
pedrobonamin
added a commit
that referenced
this pull request
Nov 11, 2024
* feat(structure): add squashed chunks to timeline * feat(structure): refactor expandable item, all items need to be rendered in the same virtual list * feat(structure): expand elements on menu click * chore(structure): clean timeline item
pedrobonamin
added a commit
that referenced
this pull request
Nov 14, 2024
* feat(structure): add squashed chunks to timeline * feat(structure): refactor expandable item, all items need to be rendered in the same virtual list * feat(structure): expand elements on menu click * chore(structure): clean timeline item
pedrobonamin
added a commit
that referenced
this pull request
Nov 18, 2024
* feat(structure): add squashed chunks to timeline * feat(structure): refactor expandable item, all items need to be rendered in the same virtual list * feat(structure): expand elements on menu click * chore(structure): clean timeline item
pedrobonamin
added a commit
that referenced
this pull request
Nov 18, 2024
* feat(structure): add squashed chunks to timeline * feat(structure): refactor expandable item, all items need to be rendered in the same virtual list * feat(structure): expand elements on menu click * chore(structure): clean timeline item
pedrobonamin
added a commit
that referenced
this pull request
Nov 19, 2024
* feat(structure): add squashed chunks to timeline * feat(structure): refactor expandable item, all items need to be rendered in the same virtual list * feat(structure): expand elements on menu click * chore(structure): clean timeline item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how the rows in the history are shown in the UI, collapsing draft edits into the publish action.
Once the draft changes are published all the draft edits done before that publish will be squashed and shown as 1 change, that could be expanded, showing also the collaborators for that published.
This means:
If we have the following mutations:
[draftEdit, publish, draftEdit, draftEdit, create]it will be shown as
[draftEdit, publish (expandable), create]On expand, it will show the two collapsed draftEdit actions
The changes are not removed from the history, they are only visually squashed for easier navigation in the UI.
The story has been updated to include this new behavior, you can check it here https://test-studio-git-corel-145.sanity.dev/test/workshop/structure;panes;documentTimelineMenu;timelineItem?scheme=light
This is achieved by creating a relation between parents publish action and children draftEdit actions, in the
addChunksMetadatafunction.Collapsable.history.items.mov
What to review
Is this correct? Are changes clear?
Testing
Notes for release
n/a