-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): stabilize studio usage of actions API #6783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated May 29, 2024 11:40 AM (UTC)
|
cngonzalez
reviewed
May 28, 2024
bjoerge
force-pushed
the
sdx-1232/stabilize-actions-api-usage
branch
from
May 29, 2024 10:32
10331cf
to
614eb98
Compare
Co-authored-by: Bjørge Næss <[email protected]> Co-authored-by: Ash <[email protected]>
…<SanityDocument> => Observable<void>
bjoerge
force-pushed
the
sdx-1232/stabilize-actions-api-usage
branch
from
May 29, 2024 11:31
614eb98
to
3a8ff7f
Compare
juice49
approved these changes
May 29, 2024
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This stabilizes internal usage of the http actions API by changing from using client.request(…) to instead use client methods introduced by sanity-io/client#818. The change should be transparent to end-users.
What to review
Testing
We should have pretty good test coverage on this already.
Notes for release
n/a