-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): unable to open block style select when in nested PTEs in fullscreen #6738
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated May 24, 2024 7:41 AM (UTC)
|
For context: There seems to be some current issues on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working as expected, thanks!
Noticed that one of the tests wasn't waiting for the nested full screen, hence the update |
Description
Fix issue where if you had nested PTEs you would not be able to open the block style dropdown
Before
Screen.Recording.2024-05-22.at.17.27.39.mov
What to review
The code makes sense, the tests make sense.
Should we add some more tests? Thought about component but since the dropdown itself existed in the UI just had the "hidden" property I considered that the e2e was the best approach. Let me know if that is not correct
Testing
Tests are written
You can also manually test on the All Bells and Whistles on the last PTE: content
Notes for release
Fixes issue where nested fullscreen PTEs were unable to open the block style dropdown