Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): symlink in local packages for the installed sanity cli #6728

Merged
merged 1 commit into from
May 21, 2024

Conversation

sgulseth
Copy link
Member

Description

We were only symlinking in local packages in the studio tests, however if the changes is only in the cli package we also need the changes locally in the installed CLI

What to review

Can this break in any, unforeseen, way? :p

Testing

Fixes the tests in #6702

Notes for release

n/a - no notes needed

@sgulseth sgulseth requested a review from bjoerge May 21, 2024 13:01
@sgulseth sgulseth requested a review from a team as a code owner May 21, 2024 13:01
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 1:04pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 1:04pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 1:04pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) May 21, 2024 1:04pm

Copy link
Contributor

No changes to documentation

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as long as the tests are green)

Copy link
Contributor

Component Testing Report Updated May 21, 2024 1:11 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 15s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 6s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 30s 12 0 0

@sgulseth sgulseth added this pull request to the merge queue May 21, 2024
Merged via the queue into next with commit c4b8558 May 21, 2024
39 checks passed
@sgulseth sgulseth deleted the chore/cli-tests-fix-local-dependencies branch May 21, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants