-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): tweak renovate preset to better align with branch rulesets #6648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated May 14, 2024 9:48 AM (UTC)
|
stipsan
added a commit
that referenced
this pull request
May 14, 2024
Follow up on #6648, the grouping didn't actually work as the `ignorePresets` directive takes presedence: https://github.com/sanity-io/sanity/blob/11dcb1ad9be866db21840b9868d6c23e934ac862/.github/renovate.json#L8
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 14, 2024
Follow up on #6648, the grouping didn't actually work as the `ignorePresets` directive takes presedence: https://github.com/sanity-io/sanity/blob/11dcb1ad9be866db21840b9868d6c23e934ac862/.github/renovate.json#L8
ricokahler
pushed a commit
that referenced
this pull request
May 14, 2024
…#6648) * chore(ci): tweak renovate preset to better align with branch rulesets * refactor(ci): only group non-major on dev/**/package.json deps
ricokahler
pushed a commit
that referenced
this pull request
May 14, 2024
Follow up on #6648, the grouping didn't actually work as the `ignorePresets` directive takes presedence: https://github.com/sanity-io/sanity/blob/11dcb1ad9be866db21840b9868d6c23e934ac862/.github/renovate.json#L8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks our Renovatebot preset to better align with changes to this repository settings since its introduction:
With those rules in mind these are the changes to our Renovate config:
"rebaseWhen": "behind-base-branch"
rule is removed since it causes Renovatebot to always rebase a PR everytime someone pushes a commit tonext
. Removing this rule allows you to queue up Renovate PRs and batch them. It also greatly reduces the amount of Vercel deployments of the test studios as Renovatebot will only automatically rebase PRs if there's a merge conflict moving forward.automerge
is set totrue
for minor and patch updates. Note that this doesn't bypass any rules such as required code review. It has the same effect as pressing "Merge when ready" manually, and allows speeding up maintenance as PRs are queued the second they have the required approvals from code owners, without waiting for another maintainer to notice that it's ready to merge.And as a bonus, for deps that live in
"dev/**/package.json"
we're now grouping deps that are minor and patch.This way the Studio DX team will no longer have to deal with these deps bumping separately:
@sanity/react-loader
@sanity/visual-editing
next
@sanity/assist