feat(pte): add initialActive prop to PortableTextInput
#6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
robinpyon
changed the title
initialActive prop to `PortableTextInputinitialActive prop to PortableTextInput
|
No changes to documentation |
robinpyon
commented
May 13, 2024
| await $pteField | ||
| .locator(`[data-testid='pt-editor__toolbar-card']`) | ||
| .waitFor({state: 'visible', timeout: 1000}) | ||
| await $overlay.waitFor({state: 'detached', timeout: 1000}) |
There was a problem hiding this comment.
Minor change – note that we now check for the overlay to be detached as opposed to checking for toolbar visibility, since this can fail with PTE inputs with hideToolbar=true
|
Component Testing Report Updated May 16, 2024 9:12 AM (UTC)
|
robinpyon
requested review from
a team and
ricokahler
and removed request for
cngonzalez and
a team
|
(Removed carolina as a reviewer as she's OOO) |
ricokahler
dismissed
jtpetty’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
initialActiveto<PortableTextInput>.This simply allows PTE inputs to be mounted without the need to manually 'activate' them by focusing beforehand.
This is used by Create as all PTE inputs there are always active by default.
What to review
Like other recent PTE changes brought in from Create, existing PTE inputs in the studio are unaffected. PTE inputs in the studio should still require activation by manually focusing / clicking them.
Testing
BlcokEditor examplesin test-studiohideToolbarandinitialFullscreenhave also been added)Notes for release
N/A