-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: inline swr
, date-fns-tz
and @vvo/tzdb
to restore embedded studios
#6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated May 2, 2024 6:51 PM (UTC)
|
rexxars
reviewed
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super happy about the lack of repro for this, but not going to let that block
rexxars
approved these changes
May 3, 2024
Me neither @rexxars, me neither 😅 |
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The deps changes in #6416 unfortunately broke some embedded studios. We don't have a reliable reproduction (I tried all the tricks I know) but we have enough user reports of embedded next studios no longer working if they upgrade from v3.38.0 and to any versions past that. Errors are usually in the form of:
The fix is to inline these dependencies, which is the tried and true fix we've used in similar cases in the past.
We've asked users that are experiencing this issue to submit a repro, once that happens I'll open another PR with a similar
test-studio
astest-next-studio
that can act as a guard against this happening again in the future.What to review
Everything in Scheduled Publishing should work as before, as we're just inlining modules we're not changing anything else.
Testing
Existing tests should be sufficient.
Notes for release
Fixes a
Attempted import error
related to usingswr