feat(comments): add telemetry #6541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated May 2, 2024 9:20 AM (UTC)
|
hermanwikner
commented
May 2, 2024
Comment on lines
-108
to
-126
| useEffect(() => { | ||
| if (mode === 'upsell') { | ||
| if (selectedPath?.origin === 'form') { | ||
| telemetryLogs.panelViewed('field_action') | ||
| } else if (commentIdParamRef.current) { | ||
| telemetryLogs.panelViewed('link') | ||
| } else { | ||
| telemetryLogs.panelViewed('document_action') | ||
| } | ||
| } | ||
| return () => { | ||
| if (mode === 'upsell') { | ||
| telemetryLogs.panelDismissed() | ||
| } | ||
| } | ||
| // We want to run this effect only on mount and unmount | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []) | ||
|
|
There was a problem hiding this comment.
Moved this effect further down
hermanwikner
requested review from
a team,
ninaandal and
joneidejohnsen
and removed request for
a team
joneidejohnsen
approved these changes
May 2, 2024
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds telemetry tracking for the following events in the comments feature:
What to review
Notes for release
N/A