perf(portable-text-editor): improve range deocration render perf #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skogsmaskin
requested review from
a team and
jordanl17
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Apr 22, 2024 4:47 PM (UTC)
|
|
I see the e2e tests picked up on something here, investigating. |
skogsmaskin
force-pushed
the
feat/range-decorations-perf-improvement
branch
from
130af19
to
202d329
Compare
This is now resolved |
skogsmaskin
force-pushed
the
feat/range-decorations-perf-improvement
branch
from
202d329
to
9cb6ada
Compare
There was an issue where decorations were returned for items that should not have decorations, causing the browser to freeze.
hermanwikner
approved these changes
Apr 22, 2024
jordanl17
pushed a commit
that referenced
this pull request
Apr 23, 2024
* feat(portable-text-editor): improve range decorations perf by comparing prev values * test(portable-text-editor): add tests for range decorations rendering * fixup! feat(portable-text-editor): improve range decorations perf by comparing prev values * test(portable-text-editor): improve some minor test things * fix(portable-text-editor): fix issue with invalid return of decorations There was an issue where decorations were returned for items that should not have decorations, causing the browser to freeze. * fix(portable-text-editor): move ref to top
cngonzalez
pushed a commit
that referenced
this pull request
May 8, 2024
* feat(portable-text-editor): improve range decorations perf by comparing prev values * test(portable-text-editor): add tests for range decorations rendering * fixup! feat(portable-text-editor): improve range decorations perf by comparing prev values * test(portable-text-editor): improve some minor test things * fix(portable-text-editor): fix issue with invalid return of decorations There was an issue where decorations were returned for items that should not have decorations, causing the browser to freeze. * fix(portable-text-editor): move ref to top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will skip unnecessary re-renders of range decorations when the previous values are the same (but the object might be different).
Also added a test for this.
What to review
Will there be a situation where we did want to re-render even though the values are the same, but the object is different? I can't think of anything, but perhaps give this an extra thought.
Testing
Covered by automatic tests
Notes for release
N/A