-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@sanity): issue where hidden unicode characters were bloating document in PTE #6424
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
* Can take a `result` JSON from a `const {result} = client.fetch(query, params, {filterResponse: false})` | ||
* and remove all stega-encoded data from it. | ||
* @alpha | ||
* @hidden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiding it since hopefully this will be added at some point to the vercel functionality (we've requested it)
@@ -0,0 +1,33 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Necessary to get the comments in vercelStegaCleanAll.ts to not scream about the @hidden
and @todo
tags
Component Testing Report Updated Apr 19, 2024 9:51 AM (UTC)
|
packages/sanity/playwright-ct/tests/formBuilder/inputs/PortableText/copyPaste/input.ts
Outdated
Show resolved
Hide resolved
…if comparing object number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 - thanks for adding tests as well
I reverted this one in Can we please remove the dep. to The HTML pre-processing should be added here instead: Could we do this stripping without bringing in that dep? I have a feeling this should be a more of a generic unused utf8-char stripper than a @vercel/stega specific one. The tests should also be added to |
Description
There was an issue where copy pasting text that had hidden unicode characters were bloating the document within the PTE. It was also visually showing the hidden unicode characters as spaces within PTE.
Before:
Screen.Recording.2024-04-19.at.09.55.55.mov
What to review
When copy and pasting for example the text from the "quickly" block into a PTE, no hidden characters will be pasted and no hidden characters will be picked up within the inspect doc.
Testing
When copy and pasting for example the text from the "quickly" block into a PTE, no hidden characters will be pasted and no hidden characters will be picked up within the inspect doc.
Can be done in any PTE within the test studio
Notes for release
Fixes issue where copy and pasting hidden unicode characters in PTE were bloating the document