Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks): update info passed to the tasks comments notification context #6087

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

pedrobonamin
Copy link
Contributor

When creating a comment inside a task we need to pass a notification context for it.
The data obtained for the context was incorrect because it was pulling from the addon workspace instead the users current workspace.
This Pr updates this to pull the data from the correct workspace.

It also moves useActivityLog to the hooks folder, and uses it from the FormEdit, given that hook needs to have access to the addon workspace.

Description

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested review from a team and ninaandal and removed request for a team March 20, 2024 14:28
Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 20, 2024 2:32pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 2:32pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 20, 2024 2:32pm

Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Mar 20, 2024 2:39 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 39s 14 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 2s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 24s 8 0 1

@pedrobonamin pedrobonamin added this pull request to the merge queue Mar 20, 2024
Merged via the queue into next with commit 6635d72 Mar 20, 2024
36 checks passed
@pedrobonamin pedrobonamin deleted the fix-tasks-notifications branch March 20, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants