Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): use relative path when globbing for files #6083

Merged

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Mar 20, 2024

Description

We were using absolute paths, so we ended up printing user information in the type comments.

Now we generate:

// Source: src/pages/resources/[slug]/index.tsx
// Variable: categoryQuery
// Query: ...

What to review

Testing

👍

Notes for release

n/a - no notes needed

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgulseth and the rest of your teammates on Graphite Graphite

@sgulseth sgulseth requested a review from kmelve March 20, 2024 13:04
@sgulseth sgulseth marked this pull request as ready for review March 20, 2024 13:05
@sgulseth sgulseth requested a review from a team as a code owner March 20, 2024 13:05
@sgulseth sgulseth requested review from cngonzalez and removed request for a team March 20, 2024 13:05
Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 20, 2024 1:50pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 1:50pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 20, 2024 1:50pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 20, 2024

Component Testing Report Updated Mar 20, 2024 1:55 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 1s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 25s 8 0 1

Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me!

@sgulseth sgulseth added this pull request to the merge queue Mar 20, 2024
Merged via the queue into next with commit 5bc629f Mar 20, 2024
36 checks passed
@sgulseth sgulseth deleted the 03-20-fix_codegen_use_relative_path_when_globbing_for_files branch March 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants