-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(codegen): move Result appending into type generation #6082
Merged
sgulseth
merged 1 commit into
next
from
03-20-refactor_codegen_move_result_appending_into_type_generation
Mar 20, 2024
Merged
refactor(codegen): move Result appending into type generation #6082
sgulseth
merged 1 commit into
next
from
03-20-refactor_codegen_move_result_appending_into_type_generation
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kmelve
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛥️
No changes to documentation |
Component Testing Report Updated Mar 20, 2024 12:59 PM (UTC)
|
sgulseth
deleted the
03-20-refactor_codegen_move_result_appending_into_type_generation
branch
March 20, 2024 13:01
hermanwikner
pushed a commit
that referenced
this pull request
Mar 21, 2024
hermanwikner
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves
Result
appending to the type identifier into the type generation. This way we can keep the actual query name across usages.What to review
Testing
👍
Notes for release
N/A - no notes needed