Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks): update how addonDatasetProvider ready state is set #6076

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Fixes an issue in which when trying to create the addon dataset through the tasks plugin, this was not being created.
This is caused because the ready: true value was only set if the dataset name exists.

By updating this, the addon provider will return ready:true after fetching the dataset, either it exists or not.
This flag is used by <TasksAddonWorkspaceProvider /> to decide if it should or not create the addon dataset.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner March 20, 2024 07:41
@pedrobonamin pedrobonamin requested review from ricokahler and removed request for a team March 20, 2024 07:41
Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 20, 2024 7:42am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 7:42am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 20, 2024 7:42am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Mar 20, 2024 7:49 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 2s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobonamin pedrobonamin added this pull request to the merge queue Mar 20, 2024
Merged via the queue into next with commit a08a82f Mar 20, 2024
36 checks passed
@pedrobonamin pedrobonamin deleted the fix-task-addon-creation branch March 20, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants