Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codegen): update help text and generated comments copy #6059

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix(codegen): update help text and generated comments copy #6059

merged 2 commits into from
Mar 19, 2024

Conversation

sgulseth
Copy link
Member

Description

Updates the copy text on typegen cmds

What to review

spelling etc

Testing

n/a

Notes for release

n/a - no notes needed

@sgulseth sgulseth requested a review from a team as a code owner March 19, 2024 15:24
@sgulseth sgulseth requested review from jtpetty and removed request for a team March 19, 2024 15:24
@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 19, 2024 3:34pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:34pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 3:34pm

kmelve
kmelve approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@kmelve kmelve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good to me. Let's probably get this merged most definitively.

packages/sanity/src/_internal/cli/actions/typegen/generateAction.ts Outdated Show resolved Hide resolved
@sgulseth @kmelve
fix: new lines
03de587 
Co-authored-by: Knut Melvær <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024 •
edited
Loading

Component Testing Report Updated Mar 19, 2024 3:50 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 58s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

@kmelve kmelve added this pull request to the merge queue Mar 19, 2024
Merged via the queue into next with commit 2afbc3b Mar 19, 2024
36 checks passed
@kmelve kmelve deleted the fix/codegen-copy branch March 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmelve kmelve kmelve approved these changes

@jtpetty jtpetty Awaiting requested review from jtpetty jtpetty was automatically assigned from sanity-io/sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgulseth @kmelve