Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks): Localize Task feature #6017

Merged
merged 5 commits into from
Mar 19, 2024
Merged

feat(tasks): Localize Task feature #6017

merged 5 commits into from
Mar 19, 2024

Conversation

jtpetty
Copy link
Contributor

@jtpetty jtpetty commented Mar 15, 2024

Fixes EDX-1072

Description

Extracting static strings for Task feature into localizable resource file

What to review

Are the key names accurate?
Did I miss any strings?

Testing

Manual testing and eslint

Notes for release

Nothing needed for release notes

@jtpetty jtpetty requested a review from a team March 15, 2024 20:01
@jtpetty jtpetty requested a review from a team as a code owner March 15, 2024 20:01
@jtpetty jtpetty requested review from pedrobonamin and rexxars and removed request for a team March 15, 2024 20:01
Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 19, 2024 3:12pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:12pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 3:12pm

Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jtpetty !
Added some comments

Copy link
Contributor

github-actions bot commented Mar 18, 2024

Package Documentation Change
@sanity/portable-text-editor +5%
sanity -2%
@sanity/diff -40%
@sanity/codegen -100%
Full Report
@sanity/portable-text-editor
This branch Next branch
23 documented 22 documented
44 not documented 45 not documented
@sanity/migrate
This branch Next branch
17 documented 17 documented
71 not documented 59 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
@sanity/types
This branch Next branch
55 documented 55 documented
234 not documented 240 not documented
sanity/desk
This branch Next branch
84 documented 84 documented
64 not documented 64 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
3 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
31 not documented 31 not documented
sanity/structure
This branch Next branch
2 documented 2 documented
8 not documented 8 not documented
@sanity/util/concurrency-limiter
This branch Next branch
1 documented 1 documented
0 not documented 0 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
4 not documented 5 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
13 not documented 13 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
17 documented 17 documented
26 not documented 26 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
@sanity/util/client
This branch Next branch
1 documented 1 documented
0 not documented 0 not documented
@sanity/util/createSafeJsonParser
This branch Next branch
1 documented 1 documented
0 not documented 0 not documented
sanity/_internalBrowser
This branch Next branch
0 documented 0 documented
3 not documented 4 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented
sanity
This branch Next branch
179 documented 183 documented
859 not documented 871 not documented
@sanity/diff
This branch Next branch
13 documented 22 documented
16 not documented 7 not documented
@sanity/codegen
This branch Next branch
0 documented 3 documented
1 not documented 1 not documented

Copy link
Contributor

github-actions bot commented Mar 18, 2024

Component Testing Report Updated Mar 19, 2024 3:20 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 59s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 24s 8 0 1

@jtpetty jtpetty added this pull request to the merge queue Mar 19, 2024
Merged via the queue into next with commit 06d812c Mar 19, 2024
36 checks passed
@jtpetty jtpetty deleted the tasks-i18n branch March 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants