fix: schema extraction object type name

[sgulseth]

Description

For some objects(I belive it's nested objects, but yet to verify) we sometimes generate object schema types with name set to object. This PR removes the _type if it's object, as it's better to miss data than to be wrong.

One example from the tests are Homestead, the compiled schema type look like:

{
  jsonType: 'object',
  type: { name: 'object', title: 'Object', type: null, jsonType: 'object' },
  name: 'object',
  title: 'Homestead',
  fields: [
    {
      name: 'lat',
      group: undefined,
      fieldset: undefined,
      type: [Object]
    },
    {
      name: 'lon',
      group: undefined,
      fieldset: undefined,
      type: [Object]
    }
  ],
  options: {},
  orderings: [
    { name: 'lat', i18n: [Object], title: 'Lat', by: [Array] },
    { name: 'lon', i18n: [Object], title: 'Lon', by: [Array] }
  ],
  fieldsets: [Getter],
  groups: [Getter],
  preview: [Getter]
}

However the field definition is:

{
  name: 'homestead',
  title: 'Homestead',
  type: 'object',
  fields: [
    {
      name: 'lat',
      title: 'Latitude',
      type: 'number',
      required: true,
    },
    {
      name: 'lon',
      title: 'Longitude',
      type: 'number',
      required: true,
    },
  ],
},

What to review

Testing

Notes for release

N/A - no notes needed

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Mar 15, 2024 1:59pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 15, 2024 1:59pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)			Mar 15, 2024 1:59pm

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Mar 15, 2024 2:06 PM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	32s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	6s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	12s	3	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	12s	4	2	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	12s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	31s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 0s	15	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 0s	18	0	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	11s	6	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	13s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	❌ Failed (Inspect)	24s	8	0	1

[bjoerge]

This looks correct to me. Values of schema types with {type: 'object'} should not get {_type: 'object'} (as it's implied). Good catch!