-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tasks): add comment delete confirm dialog #6009
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
830d26a
to
002614c
Compare
Component Testing Report Updated Mar 18, 2024 12:09 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hermanwikner !
Given we are including more things that are comment specific logic into TaskActivityLog
What do you think if we move the new addition and this component to it's own file, maybe: TasksActivityCommentItem.tsx
?
Thanks @pedrobonamin! Good suggestion, I pushed a commit that creates a dedicated component for the comment item |
Description
This pull request implements a confirmation dialog for deleting task comments to prevent accidental deletion of comments.
What to review
Notes for release
N/A