Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks): add comment delete confirm dialog #6009

Merged
merged 2 commits into from
Mar 18, 2024
Merged

feat(tasks): add comment delete confirm dialog #6009

merged 2 commits into from
Mar 18, 2024

Conversation

hermanwikner
Copy link
Member

Description

This pull request implements a confirmation dialog for deleting task comments to prevent accidental deletion of comments.

What to review

  • Make sure that the dialog appear and that the deletion is successfully executed

Notes for release

N/A

@hermanwikner hermanwikner requested review from a team, ninaandal and pedrobonamin and removed request for a team March 15, 2024 10:50
Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 18, 2024 0:04am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 0:04am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 0:04am

Copy link
Contributor

github-actions bot commented Mar 15, 2024

No changes to documentation

@hermanwikner hermanwikner force-pushed the edx-1188 branch 2 times, most recently from 830d26a to 002614c Compare March 15, 2024 10:58
Copy link
Contributor

github-actions bot commented Mar 15, 2024

Component Testing Report Updated Mar 18, 2024 12:09 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 59s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 1m 7s 17 0 1
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hermanwikner !

Given we are including more things that are comment specific logic into TaskActivityLog What do you think if we move the new addition and this component to it's own file, maybe: TasksActivityCommentItem.tsx ?

@hermanwikner
Copy link
Member Author

Thanks @hermanwikner !

Given we are including more things that are comment specific logic into TaskActivityLog What do you think if we move the new addition and this component to it's own file, maybe: TasksActivityCommentItem.tsx ?

Thanks @pedrobonamin! Good suggestion, I pushed a commit that creates a dedicated component for the comment item

@hermanwikner hermanwikner added this pull request to the merge queue Mar 18, 2024
Merged via the queue into next with commit c105115 Mar 18, 2024
36 checks passed
@hermanwikner hermanwikner deleted the edx-1188 branch March 18, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants