-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tasks): add notification data for tasks document and tasks comments #5998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
pedrobonamin
requested review from
a team and
jtpetty
and removed request for
a team
March 14, 2024 09:16
No changes to documentation |
Component Testing Report Updated Mar 14, 2024 2:21 PM (UTC)
|
jtpetty
reviewed
Mar 14, 2024
packages/sanity/src/tasks/src/tasks/components/activity/TasksActivityLog.tsx
Show resolved
Hide resolved
packages/sanity/src/tasks/src/tasks/components/activity/TasksActivityLog.tsx
Outdated
Show resolved
Hide resolved
...ages/sanity/src/tasks/src/tasks/components/form/tasksFormBuilder/TasksNotificationTarget.tsx
Outdated
Show resolved
Hide resolved
jtpetty
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the necessary changes for the notification context that will be received by the server when a task is created or edited and when a comment is added to a task.
Tasks documents
The following
context.notification
data will be addedComments
When a comment is added into a task, the notification payload will have the same properties as in a field comment and will also include the tasks subscribers ids.
What to review
Testing
Notes for release