Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle no user id in getUser #5992

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(core): handle no user id in getUser #5992

merged 1 commit into from
Mar 14, 2024

Conversation

hermanwikner
Copy link
Member

Description

This pull request ensures that we do not proceed with fetching the user with getUser in createUserStore if there's no user id available. This is added because if there's no user id provided, we know that the fetch will fail. So, we can prevent the request from erroring by returning early instead.

What to Review

  • Make sure that getUser works as before.
  • Does the change make sense?

Notes for Release

N/A

@hermanwikner hermanwikner requested a review from a team as a code owner March 13, 2024 16:55
@hermanwikner hermanwikner requested review from ricokahler and jtpetty and removed request for a team March 13, 2024 16:55
Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 13, 2024 5:00pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 5:00pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 5:00pm

Copy link
Contributor

github-actions bot commented Mar 13, 2024

No changes to documentation

Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Component Testing Report Updated Mar 13, 2024 5:04 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

@hermanwikner hermanwikner added this pull request to the merge queue Mar 14, 2024
Merged via the queue into next with commit c9ceac0 Mar 14, 2024
36 checks passed
@hermanwikner hermanwikner deleted the fix/get-user branch March 14, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants