Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): pin typescript to 5.3 #5984

Merged
merged 2 commits into from
Mar 12, 2024
Merged

chore(deps): pin typescript to 5.3 #5984

merged 2 commits into from
Mar 12, 2024

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Mar 12, 2024

Description

This is a temporary workaround for some weird build issues we've been seeing locally today.

TL;DR: Running:

pnpm i --frozen-lockfile && pnpm -r --filter='./packages/*' --filter='./packages/@sanity/*' build

from a fresh clone of this repo fails with the error:

sanity:build: [error] Internal Error: Cannot assign isExternal=false for the symbol KeyedSegment \
 because it was previously registered with isExternal=true

What to review

  • A new clone of this repo and running the above command should not fail.

Notes for release

n/a

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 12, 2024 5:55pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 5:55pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 5:55pm

Copy link
Contributor

github-actions bot commented Mar 12, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Component Testing Report Updated Mar 12, 2024 5:44 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 14s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 2s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

@bjoerge bjoerge changed the title Fix/downgrade ts chore(deps): pin typescript to 5.3 Mar 12, 2024
@bjoerge bjoerge marked this pull request as ready for review March 12, 2024 17:53
@bjoerge bjoerge requested a review from a team as a code owner March 12, 2024 17:53
@bjoerge bjoerge requested review from ricokahler and removed request for a team March 12, 2024 17:53
@bjoerge bjoerge added this pull request to the merge queue Mar 12, 2024
Merged via the queue into next with commit 193b4b8 Mar 12, 2024
37 checks passed
@bjoerge bjoerge deleted the fix/downgrade-ts branch March 12, 2024 18:07
juice49 pushed a commit that referenced this pull request Mar 13, 2024
* chore: pin typescript to 5.3

* fix(types): add ts-expect-error to tests
juice49 added a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants