Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add navbar actions (@internal) #5968

Merged
merged 2 commits into from
Mar 12, 2024
Merged

feat(core): add navbar actions (@internal) #5968

merged 2 commits into from
Mar 12, 2024

Conversation

hermanwikner
Copy link
Member

@hermanwikner hermanwikner commented Mar 12, 2024 •
edited
Loading

Description

This pull request replaces the rightSectionNode option in NavbarProps with a new NavbarAction[] option. This API enables the definition of actions to be rendered in the navbar. Note that it is intended for use by internal features only.

Notes for release

N/A

@hermanwikner hermanwikner requested a review from a team March 12, 2024 11:14
@hermanwikner hermanwikner requested a review from a team as a code owner March 12, 2024 11:14
@hermanwikner hermanwikner requested review from sjelfull and binoy14 and removed request for a team March 12, 2024 11:14
@vercel Vercel
Copy link

vercel bot commented Mar 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 12, 2024 0:12am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 0:12am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 0:12am

@hermanwikner hermanwikner requested review from bjoerge and pedrobonamin and removed request for sjelfull and binoy14 March 12, 2024 11:14
@hermanwikner hermanwikner changed the title feat(core): add navbar actions API (@internal) feat(core): add navbar actions (@internal) Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

pedrobonamin
pedrobonamin approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hermanwikner

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

Component Testing Report Updated Mar 12, 2024 11:58 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 59s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@hermanwikner hermanwikner marked this pull request as draft March 12, 2024 11:33
@hermanwikner hermanwikner marked this pull request as ready for review March 12, 2024 11:40
@hermanwikner hermanwikner added this pull request to the merge queue Mar 12, 2024
Merged via the queue into next with commit 8336c9f Mar 12, 2024
36 checks passed
@hermanwikner hermanwikner deleted the feat/navbar-actions branch March 12, 2024 12:15
juice49 pushed a commit that referenced this pull request Mar 13, 2024
@hermanwikner @juice49
feat(core): add navbar actions (@internal) (#5968)
5c9fb85 
* feat(core): add navbar actions (`@internal`)

* refactor(tasks): use navbar actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobonamin pedrobonamin pedrobonamin approved these changes

@bjoerge bjoerge Awaiting requested review from bjoerge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hermanwikner @pedrobonamin