Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): exclude the github reporter from playwright tests for now #5959

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Mar 11, 2024

Description

Disabling the github reporter from playwright config for now, as it adds too much noise to be useful (see https://github.com/sanity-io/sanity/pull/5950/files for an example). Figured it was better to disable it for our repo, since removing it from the default reporters defined by @sanity/test could lead to unsurprising behavior for other consumers of that package.

What to review

Will this actually remove the reporter?

Notes for release

n/a – internal

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 11, 2024 4:25pm
test-studio ✅ Ready (Inspect) Visit Preview Mar 11, 2024 4:25pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 11, 2024 4:25pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Mar 11, 2024 4:31 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 1s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@bjoerge bjoerge marked this pull request as ready for review March 11, 2024 16:51
@bjoerge bjoerge requested a review from a team as a code owner March 11, 2024 16:52
@bjoerge bjoerge requested review from ricokahler and removed request for a team March 11, 2024 16:52
@bjoerge bjoerge added this pull request to the merge queue Mar 12, 2024
Merged via the queue into next with commit 334917f Mar 12, 2024
36 checks passed
@bjoerge bjoerge deleted the fix/remove-github-reporter-from-e23-tests branch March 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants