Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update @sanity/icons #5956

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix(deps): update @sanity/icons #5956

merged 2 commits into from
Mar 12, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Updates @sanity/icons to latest version to include the new Task icon.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner March 11, 2024 15:34
@pedrobonamin pedrobonamin requested review from cngonzalez and removed request for a team March 11, 2024 15:34
Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 12, 2024 8:12am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 8:12am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 8:12am

Copy link

socket-security bot commented Mar 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sanity/[email protected] None 0 1.23 MB sanity-io

🚮 Removed packages: npm/@sanity/[email protected]

View full report↗︎

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Component Testing Report Updated Mar 12, 2024 8:17 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 30s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 58s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

Copy link
Member

@cngonzalez cngonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! Do we expect the CLI templates to use tasks too? I see a few in packages/@sanity/cli/src/actions that are at ^2.6. I don't think it's a big deal (or if maintaining those templates is in our scope) since we have the caret, but just wanted to ensure there'd be no unexpected behavior down the line.

@pedrobonamin
Copy link
Contributor Author

Exciting! Do we expect the CLI templates to use tasks too? I see a few in packages/@sanity/cli/src/actions that are at ^2.6. I don't think it's a big deal (or if maintaining those templates is in our scope) since we have the caret, but just wanted to ensure there'd be no unexpected behavior down the line.

I don't see any downside on updating also those, will update them.

@pedrobonamin pedrobonamin added this pull request to the merge queue Mar 12, 2024
Merged via the queue into next with commit 15f53bd Mar 12, 2024
36 checks passed
@pedrobonamin pedrobonamin deleted the update-deps branch March 12, 2024 08:30
ninaandal pushed a commit that referenced this pull request Mar 12, 2024
* fix(deps): update '@sanity/icons'

* fix(templates): update sanity icons library used in templates
juice49 pushed a commit that referenced this pull request Mar 13, 2024
* fix(deps): update '@sanity/icons'

* fix(templates): update sanity icons library used in templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants