feat(comments): support task comments #5934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
hermanwikner
force-pushed
the
feat/comments-task-support
branch
from
05462f7
to
3ac1cbf
Compare
|
Component Testing Report Updated Mar 8, 2024 1:20 PM (UTC)
|
hermanwikner
requested review from
a team,
skogsmaskin and
pedrobonamin
and removed request for
a team
pedrobonamin
approved these changes
Mar 8, 2024
hermanwikner
changed the title
juice49
pushed a commit
that referenced
this pull request
Mar 13, 2024
* feat(comments): support task comments * fix(comments): omit `payload` when creating new thread * chore(eslint): add "sortOrder" to `ignores.attributes` * fix(comments): remove eslint ignore comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a
typeconfiguration to the comments feature ("field" | "task") to enable the creation of comments in the upcoming Tasks feature. Additionally, the UI components have been made somewhat less tied to the field comments scenario by moving the previously requiredfieldPathvalue to an optionalpayloadproperty. Although the UI components are still somewhat tied to the field comments scenario, this change is a step in the right direction towards making them more generic and adaptable to other contexts, such as when creating comments on tasks.What to review
Notes for release
N/A