fix(ci): align pnpm install across all workflows #5920

bjoerge · 2024-03-06T17:02:11Z

Description

This aligns how we install dependencies across all our workflow definitions. It's using the same approach as @binoy14 previously added for the e2e test workflow.

What to review

Should we always pass --config.ignore-scripts=true when running pnpm install? (side note: why the config.-prefix and not just --ignore-scripts?)

Testing

CI is taking care of it!

Notes for release

n/a internal

vercel · 2024-03-06T17:02:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Mar 8, 2024 4:25pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 8, 2024 4:25pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Mar 8, 2024 4:25pm

github-actions · 2024-03-06T17:03:17Z

No changes to documentation

github-actions · 2024-03-06T17:08:45Z

Component Testing Report Updated Mar 8, 2024 4:30 PM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	30s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	5s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	12s	3	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	12s	4	2	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	12s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	30s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	58s	15	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	❌ Failed (Inspect)	1m 3s	17	0	1
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	11s	6	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	12s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	19s	9	0	0

bjoerge · 2024-03-06T19:16:40Z

.github/workflows/test.yml

-      - name: Install project dependencies
-        run: pnpm install
-
-      - name: Build CLI


this was probably just leftover cruft, and there was no point in running build during the install step, so moved building to right before running the tests below

actually I misunderstood this, so the way this is working is it's running the build step in install job, so it builds for node18 and node20 then it caches the build and passes it to the test job which runs for a mix of node + shard matrix if the build step is still needed we should keep the cache so it doesn't need to build on each matrix which would take quite long for 4 shards if cache is not available.

I thought the build step isn't required at all but maybe that will not work. Happy to chat more on this

I thought the build step isn't required at all

You're right! Jest is configured to use the dev aliases, so tests can run from source. Although discovered that the validation tests, requires these aliases to be registered inside the worker thread that it runs.

Opened a separate PR to address this here: #5927

Modified this PR to instead remove build entirely from the test workflow, so it should run a lot faster now.

.github/workflows/test.yml

Unit tests doesn't require packages to be built since jest is configured to use the devAliases, routing imports from `<package>` to `<package>/src`.

binoy14

very nice thank you for doing it.

Small note the install job and the cleanup jobs can be removed for the test action since they are not doing anything

* fix(ci): align pnpm install across all workflows * fix(ci): skip running build before unit tests Unit tests doesn't require packages to be built since jest is configured to use the devAliases, routing imports from `<package>` to `<package>/src`. * fixup! fix(ci): skip running build before unit tests

vercel bot deployed to Preview – test-studio March 6, 2024 17:02 View deployment

bjoerge force-pushed the fix/ci-align-pnpm-install branch from e2ee755 to 0688101 Compare March 6, 2024 17:05

vercel bot deployed to Preview – performance-studio March 6, 2024 17:05 View deployment

vercel bot deployed to Preview – test-studio March 6, 2024 17:06 View deployment

vercel bot deployed to Preview – performance-studio March 6, 2024 17:15 View deployment

vercel bot deployed to Preview – test-studio March 6, 2024 17:15 View deployment

vercel bot deployed to Preview – performance-studio March 6, 2024 17:20 View deployment

vercel bot deployed to Preview – test-studio March 6, 2024 17:20 View deployment

vercel bot deployed to Preview – performance-studio March 6, 2024 17:25 View deployment

vercel bot deployed to Preview – test-studio March 6, 2024 17:25 View deployment

vercel bot deployed to Preview – performance-studio March 6, 2024 17:38 View deployment

vercel bot deployed to Preview – test-studio March 6, 2024 17:38 View deployment

vercel bot deployed to Preview – performance-studio March 6, 2024 17:48 View deployment

vercel bot deployed to Preview – test-studio March 6, 2024 17:49 View deployment

bjoerge force-pushed the fix/ci-align-pnpm-install branch from 8396231 to f0a3227 Compare March 6, 2024 17:59

vercel bot deployed to Preview – performance-studio March 6, 2024 18:00 View deployment

vercel bot deployed to Preview – test-studio March 6, 2024 18:00 View deployment

vercel bot deployed to Preview – performance-studio March 6, 2024 18:10 View deployment

vercel bot deployed to Preview – test-studio March 6, 2024 18:11 View deployment

bjoerge force-pushed the fix/ci-align-pnpm-install branch from b012966 to cd193b8 Compare March 6, 2024 19:09

bjoerge commented Mar 6, 2024

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

vercel bot deployed to Preview – test-studio March 6, 2024 19:18 View deployment

vercel bot deployed to Preview – performance-studio March 6, 2024 19:18 View deployment

bjoerge marked this pull request as ready for review March 6, 2024 19:33

bjoerge requested a review from a team as a code owner March 6, 2024 19:33

bjoerge removed the request for review from a team March 6, 2024 19:33

bjoerge requested review from binoy14 and stipsan March 6, 2024 19:33

bjoerge mentioned this pull request Mar 7, 2024

test(sanity): use dev aliases in the validation test's worker threads #5927

Merged

bjoerge force-pushed the fix/ci-align-pnpm-install branch from cd193b8 to 5d3fc77 Compare March 7, 2024 10:29

vercel bot deployed to Preview – performance-studio March 7, 2024 10:29 View deployment

vercel bot deployed to Preview – test-studio March 7, 2024 10:30 View deployment

bjoerge added 2 commits March 8, 2024 11:27

fix(ci): align pnpm install across all workflows

3f129d7

fix(ci): skip running build before unit tests

b0f8418

Unit tests doesn't require packages to be built since jest is configured to use the devAliases, routing imports from `<package>` to `<package>/src`.

bjoerge force-pushed the fix/ci-align-pnpm-install branch from 5d3fc77 to b0f8418 Compare March 8, 2024 10:27

vercel bot deployed to Preview – performance-studio March 8, 2024 10:31 View deployment

vercel bot deployed to Preview – test-studio March 8, 2024 10:32 View deployment

binoy14 approved these changes Mar 8, 2024

View reviewed changes

vercel bot deployed to Preview – performance-studio March 8, 2024 16:16 View deployment

vercel bot deployed to Preview – test-studio March 8, 2024 16:17 View deployment

fixup! fix(ci): skip running build before unit tests

fe46f4c

bjoerge force-pushed the fix/ci-align-pnpm-install branch from c310516 to fe46f4c Compare March 8, 2024 16:24

vercel bot deployed to Preview – performance-studio March 8, 2024 16:25 View deployment

vercel bot deployed to Preview – test-studio March 8, 2024 16:25 View deployment

bjoerge added this pull request to the merge queue Mar 8, 2024

Merged via the queue into next with commit f103967 Mar 8, 2024
35 of 36 checks passed

bjoerge deleted the fix/ci-align-pnpm-install branch March 8, 2024 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ci): align pnpm install across all workflows #5920

fix(ci): align pnpm install across all workflows #5920

bjoerge commented Mar 6, 2024 •

edited

Loading

vercel bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

bjoerge Mar 6, 2024

binoy14 Mar 6, 2024

bjoerge Mar 7, 2024 •

edited

Loading

bjoerge Mar 7, 2024

binoy14 left a comment

fix(ci): align pnpm install across all workflows #5920

fix(ci): align pnpm install across all workflows #5920

Conversation

bjoerge commented Mar 6, 2024 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 6, 2024 • edited Loading

bjoerge Mar 6, 2024

Choose a reason for hiding this comment

binoy14 Mar 6, 2024

Choose a reason for hiding this comment

bjoerge Mar 7, 2024 • edited Loading

Choose a reason for hiding this comment

bjoerge Mar 7, 2024

Choose a reason for hiding this comment

binoy14 left a comment

Choose a reason for hiding this comment

bjoerge commented Mar 6, 2024 •

edited

Loading

vercel bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

bjoerge Mar 7, 2024 •

edited

Loading