Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): update placeholder text to be more clear and accessible #5910

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix(core): update placeholder text to be more clear and accessible #5910

merged 1 commit into from
Mar 6, 2024

Conversation

jtpetty
Copy link
Contributor

@jtpetty jtpetty commented Mar 5, 2024

Description

Fixes EDX-1123

Updates copy for placeholder text

Before:
image

After:
image

What to review

Typos?

Testing

Copy only change, no functional change

@jtpetty jtpetty requested a review from a team as a code owner March 5, 2024 18:29
@jtpetty jtpetty requested review from bjoerge and removed request for a team March 5, 2024 18:29
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 5, 2024 6:31pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 6:31pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 5, 2024 6:31pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Component Testing Report Updated Mar 5, 2024 6:38 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 2s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 21s 9 0 0

bjoerge
bjoerge approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpetty jtpetty added this pull request to the merge queue Mar 6, 2024
Merged via the queue into next with commit 9978095 Mar 6, 2024
40 checks passed
@jtpetty jtpetty deleted the edx-1123 branch March 6, 2024 15:42
ricokahler pushed a commit that referenced this pull request Mar 6, 2024
@jtpetty @ricokahler
fix(core): update placeholder text to be more clear and accessible (#…
f616dd5 
…5910)
juice49 pushed a commit that referenced this pull request Mar 13, 2024
@jtpetty @juice49
fix(core): update placeholder text to be more clear and accessible (#…
e6cbc19 
…5910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpetty @bjoerge