-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): improve migration runner output #5904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Mar 13, 2024 4:54 PM (UTC)
|
juice49
force-pushed
the
feat/improve-migration-runner-messages
branch
from
March 5, 2024 10:03
d529cd2
to
b009948
Compare
rexxars
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
packages/sanity/src/_internal/cli/commands/migration/runMigrationCommand.ts
Outdated
Show resolved
Hide resolved
packages/sanity/src/_internal/cli/commands/migration/runMigrationCommand.ts
Outdated
Show resolved
Hide resolved
juice49
force-pushed
the
feat/improve-migration-runner-messages
branch
from
March 13, 2024 16:38
feb2431
to
cda4a56
Compare
juice49
force-pushed
the
feat/improve-migration-runner-messages
branch
from
March 13, 2024 16:42
d1d34ef
to
7bfbfe9
Compare
juice49
changed the title
Feat/improve migration runner messages
feat(cli): improve migration runner output
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
migration run
commands can be run from any Studio project subdirectory, but their output messages currently assume the user is in the project root. This branch makes the output clearer, and adds consistent list formatting when multiple migrations are found.Before
When no migrations found
When multiple migrations found
After
When no migrations found
When multiple migrations found
What to review
Do the adjusted output messages make sense?
Testing
Attempt to run migrations that are nonexistent, or have multiple matching scripts, from both a Studio project root directory and a Studio project subdirectory.