Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): change modalWidth of inlineObjects to 1 by default #5839

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

ninaandal
Copy link
Contributor

@ninaandal ninaandal commented Feb 26, 2024

Description

This PR changes the inline objects in portable text to be wider by default.
There has been a lot of signal of the reference picker being too narrow. After talking with design, the decision landed on making the default width of all inline objects larger (but might revisit later)

What to review

The reference picker/objects popovers in for example in the portable text in Standard inputs - Portable text - All the editors!

Testing

Notes for release

Increases default size of inline objects in portable text

@ninaandal ninaandal requested review from a team and pedrobonamin and removed request for a team February 26, 2024 15:01
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 27, 2024 1:30pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 1:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 1:30pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 26, 2024

Component Testing Report Updated Feb 27, 2024 1:34 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 58s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

@ninaandal ninaandal marked this pull request as draft February 26, 2024 15:52
@ninaandal ninaandal marked this pull request as ready for review February 27, 2024 13:27
@ninaandal ninaandal changed the title fix(core): change modalWidth of reference to 1 by default fix(core): change modalWidth of inlineObjects to 1 by default Feb 27, 2024
Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks nina!

@ninaandal ninaandal added this pull request to the merge queue Feb 28, 2024
Merged via the queue into next with commit 6e551b0 Feb 28, 2024
40 checks passed
@ninaandal ninaandal deleted the edx-787 branch February 28, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants