Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add onDoubleClick to open image crop #5815

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix(core): add onDoubleClick to open image crop #5815

merged 1 commit into from
Mar 8, 2024

Conversation

ninaandal
Copy link
Contributor

@ninaandal ninaandal commented Feb 21, 2024

Description

This PR adds an onDoubleClick to the ImagePreview component and opens the Crop image dialog when the image preview is double clicked.

What to review

Go to an asset with an image preview and with the ability to crop this image, and double click on the image - it will open the Crop image dialog.

Testing

Notes for release

Adds ability to open 'Crop image' dialog by double clicking image preview

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 26, 2024 8:51pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 8:51pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 8:51pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Component Testing Report Updated Feb 26, 2024 8:55 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 57s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@ninaandal ninaandal marked this pull request as ready for review February 22, 2024 15:01
@ninaandal ninaandal requested a review from a team as a code owner February 22, 2024 15:01
@ninaandal ninaandal requested review from ricokahler and removed request for a team February 22, 2024 15:01
@jtpetty jtpetty added this pull request to the merge queue Mar 8, 2024
Merged via the queue into next with commit e3bfee0 Mar 8, 2024
40 checks passed
@jtpetty jtpetty deleted the edx-853 branch March 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants