Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(playwright-ct): fix some webkit flakyness in PT-Input tests #5811

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

skogsmaskin
Copy link
Member

Description

This will fix some flakiness in the Playwright Components tests for Webkit.

What to review

That the Input.spec.tsx doesn't error on Webkit.

Testing

N/A

Notes for release

N/A

@skogsmaskin skogsmaskin requested a review from a team as a code owner February 21, 2024 12:14
@skogsmaskin skogsmaskin requested review from binoy14 and juice49 and removed request for a team February 21, 2024 12:14
Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 21, 2024 0:19am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 0:19am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2024 0:19am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Feb 21, 2024 12:23 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 5s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@skogsmaskin skogsmaskin added this pull request to the merge queue Feb 21, 2024
Merged via the queue into next with commit 981a4bd Feb 21, 2024
40 checks passed
@skogsmaskin skogsmaskin deleted the test/fix-webkit-flake branch February 21, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants