Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): setup pnpm #5800

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix(ci): setup pnpm #5800

merged 1 commit into from
Feb 20, 2024

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Feb 20, 2024

Description

Setup pnpm and installed dependencies.

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 20, 2024 4:37pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 4:37pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 20, 2024 4:37pm

Copy link
Contributor

No changes to documentation

@juice49 juice49 added this pull request to the merge queue Feb 20, 2024
Merged via the queue into next with commit 83630cf Feb 20, 2024
24 of 27 checks passed
@juice49 juice49 deleted the fix/release-with-pnpm branch February 20, 2024 16:40
Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some caching changes for future improvements

@@ -32,8 +32,11 @@ jobs:
cache: 'pnpm'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this

uses: pnpm/action-setup@v3
with:
version: 8
run_install: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to run this as a different step

Suggested change
run_install: true
run_install: false

uses: pnpm/action-setup@v3
with:
version: 8
run_install: true

- name: Pre-flight
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Pre-flight
- name: Install project dependencies
run: pnpm install
- name: Pre-flight

Copy link
Contributor

Component Testing Report Updated Feb 20, 2024 4:44 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 41s 14 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 17s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 59s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants