fix(pte): PTE modal re-render on validation state change due to tooltip disabled change #5766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there are validation errors the tooltip is enabled, when validation errors disappear the tooltip is disabled.
Making that update when the modal is rendered it will trigger a "unmount" and "re-mount" of the BlockObject causing the modal to unmount and remount, triggering the animation again and losing the input focus.
By checking if the modal is open to enable / disable the tooltip, we can be sure that this component won't unmount and mount causing this unwanted issues.
Screen.Recording.2024-02-16.at.11.29.58.mov
What to review
PTE dialogs and tooltips work as always
Testing
Create a new object within pte with validation eror
Notes for release