Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing types packages #5751

Merged
merged 1 commit into from
Feb 15, 2024
Merged

chore: add missing types packages #5751

merged 1 commit into from
Feb 15, 2024

Conversation

skogsmaskin
Copy link
Member

Add missing types for lodash and react-dom in various packages.

@skogsmaskin
chore: add missing types packages
f104bf5 
Add missing types for lodash and react-dom in various packages.
@skogsmaskin skogsmaskin requested a review from a team as a code owner February 15, 2024 13:26
@skogsmaskin skogsmaskin requested review from binoy14 and removed request for a team February 15, 2024 13:26
@vercel Vercel
Copy link

vercel bot commented Feb 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 15, 2024 1:30pm
test-studio 🔄 Building (Inspect) Visit Preview Feb 15, 2024 1:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 1:30pm

bjoerge
bjoerge approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skogsmaskin! Would be interesting to understand why pnpm didn't cause these to produce errors elsewhere (CI, etc), but that's for another day

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@skogsmaskin skogsmaskin added this pull request to the merge queue Feb 15, 2024
Merged via the queue into next with commit 656bec2 Feb 15, 2024
20 of 22 checks passed
@skogsmaskin skogsmaskin deleted the chore-add-missing-deps branch February 15, 2024 13:30
@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Feb 15, 2024 1:34 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 17s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@binoy14 binoy14 mentioned this pull request Feb 15, 2024
Closed
juice49 pushed a commit that referenced this pull request Feb 16, 2024
@skogsmaskin @juice49
chore: add missing types packages (#5751)
22c9747 
Add missing types for lodash and react-dom in various packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

@binoy14 binoy14 Awaiting requested review from binoy14 binoy14 was automatically assigned from sanity-io/sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skogsmaskin @bjoerge