-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tasks): add assignee property to tasks #5745
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, left a few nits/questions.
packages/sanity/src/tasks/src/tasks/components/create/TasksCreate.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/tasks/src/tasks/components/create/TasksCreate.tsx
Outdated
Show resolved
Hide resolved
@@ -1,11 +1,12 @@ | |||
import {useCallback, useEffect, useRef, useState} from 'react' | |||
import {Box, Card, Flex, Stack, Text, TextInput, useToast} from '@sanity/ui' | |||
import {Card, Flex, Stack, Text, TextInput, useToast} from '@sanity/ui' | |||
import {PortableTextBlock} from '@sanity/types' | |||
import {Button} from '../../../../../ui-components' | |||
import {useTasks} from '../../context' | |||
import {CommentInput, useMentionOptions} from '../../../../../structure/comments' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we import from structure into core? Not sure that is possible, meaning we might need refactor these once they go into the main tasks branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would probably want to move the reusable components and hooks into core. I'll create another Pr for this standalone changes.
cc5c7c7
to
d6911a2
Compare
11502c2
to
9ee92cc
Compare
No changes to documentation |
Component Testing Report Updated Feb 15, 2024 2:15 PM (UTC)
|
Description
Adds assignedTo property to tasks.
When a user is assigned, he will see that task in his list of tasks.
What to review
AssignedTo property works as expected
Testing
Create a new task, assign yourself or any other user, it should work.
Notes for release