Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks): add assignee property to tasks #5745

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

pedrobonamin
Copy link
Contributor

Description

Adds assignedTo property to tasks.
When a user is assigned, he will see that task in his list of tasks.

Screenshot 2024-02-15 at 09 30 16 Screenshot 2024-02-15 at 09 30 22

What to review

AssignedTo property works as expected

Testing

Create a new task, assign yourself or any other user, it should work.

Notes for release

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 15, 2024 2:11pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 2:11pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 15, 2024 2:11pm

@pedrobonamin pedrobonamin changed the title Edx 1096 feat(tasks): add assignee property to tasks Feb 15, 2024
@pedrobonamin pedrobonamin marked this pull request as ready for review February 15, 2024 08:36
@pedrobonamin pedrobonamin requested a review from a team as a code owner February 15, 2024 08:36
@pedrobonamin pedrobonamin requested review from binoy14 and removed request for a team February 15, 2024 08:36
Copy link
Member

@sjelfull sjelfull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, left a few nits/questions.

@@ -1,11 +1,12 @@
import {useCallback, useEffect, useRef, useState} from 'react'
import {Box, Card, Flex, Stack, Text, TextInput, useToast} from '@sanity/ui'
import {Card, Flex, Stack, Text, TextInput, useToast} from '@sanity/ui'
import {PortableTextBlock} from '@sanity/types'
import {Button} from '../../../../../ui-components'
import {useTasks} from '../../context'
import {CommentInput, useMentionOptions} from '../../../../../structure/comments'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we import from structure into core? Not sure that is possible, meaning we might need refactor these once they go into the main tasks branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would probably want to move the reusable components and hooks into core. I'll create another Pr for this standalone changes.

@pedrobonamin pedrobonamin requested a review from a team February 15, 2024 13:18
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Feb 15, 2024 2:15 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 17s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 59s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@pedrobonamin pedrobonamin merged commit 5a1c4ea into edx-986-plugin Feb 15, 2024
39 of 40 checks passed
@pedrobonamin pedrobonamin deleted the edx-1096 branch February 15, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants