Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(comments): improve i18n resource for comment contexts #5731

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

rdunk
Copy link
Member

@rdunk rdunk commented Feb 14, 2024

Description

Updated comment for an i18n resource to provide more context for translators. Specifically the text used for rendering intent links to navigate back to where a comment was made, e.g. in Presentation tool.

What to review

The text provides enough context for community and AI translators to provide an accurate translation.

Testing

N/A

Notes for release

N/A

@rdunk rdunk requested review from a team and jtpetty and removed request for a team February 14, 2024 10:25
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 14, 2024 10:26am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 10:26am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 14, 2024 10:26am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Feb 14, 2024 10:33 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 18s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

@rexxars rexxars added this pull request to the merge queue Feb 14, 2024
Merged via the queue into next with commit 6d5008d Feb 14, 2024
40 checks passed
@rexxars rexxars deleted the chore/improve-comment-i18n branch February 14, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants